feat(browser): Add View Hierarchy integration#14981
Conversation
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
|
woah what does it look like with minified class names? (and you don't have react component annotations or similar?) |
|
By default it's capturing Here is the full event: |
Codecov Results 📊Generated by Codecov Action |
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
size-limit report 📦
|
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you apply the label |
|
Closing due to inactivity after stale warning. Comment or reopen when ready to continue, and use |
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Browser
Deps
Nuxt
Other
Bug Fixes 🐛
Documentation 📚
Internal Changes 🔧Core
Deps
Deps Dev
Other
🤖 This preview updates automatically when you update the PR. |
|
@timfish anything that we still need to change here to get this out of draft? |
|
I need to add an integration test and maybe some bike shedding on the export name. I think "view hierarchy" isn't that descriptive of what it does and just describes our internal naming! |
|
I think "View Hierarchy" already has precedence since the mobile SDKs already ship it like this (e.g. React Native) and it's what the feature is called in the Sentry UI. Do you have other ideas? I could see going with something more DOM or component-related but from my PoV, View Hierarchy is also fine. |
By default it captures the entire DOM, but it is configurable:
Capture only React components (uses attributes added by Sentry bundler plugins):
Capture only Web Components: